Joshua Barretto

Results 755 comments of Joshua Barretto

Hi, looks like you need to enable the `pratt` feature for the `indent` example in `Cargo.toml`. My feeling is that we should keep the pratt parser here simple, simpler than...

I am unconvinced that `smallvec` would actually be an optimisation. `Vec` only allocates when growing beyond its previous largest capacity, because it doesn't implicitly shrink. Therefore, the amortised cost of...

What is the type signature of `block_parser`? This looks suspiciously like the issue mentioned [here](https://github.com/zesterer/chumsky/issues/747#issuecomment-2781473616).

> Here is the signature: > > pub fn block_parser> + Clone > where > I: ValueInput, Span = SimpleSpan>, > { I think you have the same problem. You're...

Hmm, I'm quite confused as to what's going on here. Is there any chance that your parser is public and I'd be able to give compiling it a go myself?

While in retrospect I would have used a different name, history is as it is now, and I don't want to be changing names and breaking parsers without a good...

I've just searched through our conversation and I can't find evidence of that, but perhaps I'm missing something. My justification is the same for other rename proposals: > I'm just...

Thanks for the contribution! Would it be possible for you to expand a little on the motivation for this? I'd think that showing the full contents of a file would...

Thanks! Looks like it needs a `cargo fmt` before merge, but I'm happy with this now.

In an unrelated change, I added the ability to specify the number of lines of context that appear around label ends. This seems to have produced some conflicts. I'm also...