flume icon indicating copy to clipboard operation
flume copied to clipboard

Implement Debug for async futures/streams

Open jf2048 opened this issue 3 years ago • 4 comments

Just for completeness, these were the only things I noticed where it was missing.

jf2048 avatar Oct 19 '22 18:10 jf2048

Thanks!

Edit: It seems like this PR is failing, perhaps it's better to implement Debug manually? Avoiding revealing internal implementation details would also be good, I think.

zesterer avatar Oct 21 '22 10:10 zesterer

Whoops, I guess my rust-analyzer had a hiccup or something :)

I changed it to have Debug on those private structs, but I also can change it to just be an empty implementation of Debug for those fields/variants, would that work?

jf2048 avatar Oct 22 '22 18:10 jf2048

Now changed it to have empty implementation

jf2048 avatar Oct 23 '22 01:10 jf2048

Thanks, this is ideal. It seems there is a conflict though, but this should be a trivial change.

zesterer avatar Oct 27 '22 12:10 zesterer