Joshua Barretto comments

Results 755 comments of


                                            Joshua Barretto

Add `SendFut::into_inner`.

This looks good to me! I initially turned my nose up at the name `into_inner`, but on second thoughts I think you're right that this does actually follow the conventions...

Add `SendFut::into_inner`.

At least now, building a timeout on top is a relatively trivial job. In terms of implementing that, I think the most lightweight and sensible solution - based on a...

Add `SendFut::into_inner`.

I think B is probably the way to go. It's an underrated thing, but being able to name the type of a feature is occasionally very important, particularly if you're...

Add `SendFut::into_inner`.

I'm so sorry, GitHub swallowed my notification for this. > @zesterer Do you want these as separate MRs, or should I add the timeout functions here in this MR? The...

`async`: `send_timeout` & `send_deadline`

Yes, this is definitely missing functionality. I think this would be *relatively* easy to implement: internally we could just use a regular old async timeout (tokio or otherwise) and then...

Update `Cargo.lock`

Thanks for the PR! @baoyachi that's traditionally been the case, yes: but the Rust project has recently changed guidance in favour of committing lockfiles for libraries. I'm personally still a...

Update `Cargo.lock`

I need to fix CI at some point.

Update `Cargo.lock`

This has since been resolved.

`lazy` would unexpectedly eat all the input.

You are correct, the behaviour is not entirely equivalent. `.lazy()` was only really intended to be used on the top-most parser to replicate the behaviour of pre-0.10 parsers, but this...

`just(range)` passes the range as output instead of the matched value (1.0.7 alpha)

I now recall why I didn't implement this: `just` accepts sequences, not just individual characters. I think this is potentially a good reason to re-deduplicate `just`, splitting it into `just`...