Zeeshan Ali Khan

Results 435 comments of Zeeshan Ali Khan
trafficstars

> That kinda ends the argument that this should be fixed in zbus rather than in xdg-dbus-proxy. That was never a good argument anyway since the bug is not in...

> Well, go dbus seems to generate serials "properly", it uses mutual lock to to it: https://github.com/godbus/dbus/blob/76236955d466b078d82dcb16b7cf1dcf40ac25df/conn.go#L834 This may not be enough. I think most (likely all) D-Bus libraries do...

> Well, I am surprised then how does this bug doesn't have a bigger impact. Any app which heavily uses D-Bus should meet this issue sooner or later. Not all...

@ankitstarski i think you can safely close this issue.

@filipkemuel seems your PR never made it in. This seems very important fix so if you could submit a PR, that would be great. I hope @ankitstarski has time to...

@ankitstarski this seems like a very serious issue so whether or not @filipkemuel has time to create a PR soon, we should look into merging their changes.

@filipkemuel yeah, thanks for the PR. Too bad @ankitstarski has disapeared completely. I hope he's OK.

> This feels like a compiler bug to me: the `get` function definition should return a value with the same lifetime as `&self`. It's very much possible. I did a...

Why create a new PR for the same exact thing? :thinking: You know you can just force push your completely new changes to the same branch, right?