Zeeshan Ali Khan comments

Results 435 comments of


                                            Zeeshan Ali Khan

trafficstars

The `se::to_writer` function now requires `std::fmt::Write` instead of `std::io::Write`

> > Is there an issue on serde_json about this? > > I don't known. While @dtolnay can be great in other projects, serde project is not in him focus...

The `se::to_writer` function now requires `std::fmt::Write` instead of `std::io::Write`

> Serde part writes only XML fragments which is not a documents, so writing they to file / network directly could be error-prone for reader (is reader expects standalone XML)....

The `se::to_writer` function now requires `std::fmt::Write` instead of `std::io::Write`

> Serde part writes only XML fragments which is not a documents BTW, is this a new behavior? I'm asking cause [my testcase now fails on reading](https://gitlab.freedesktop.org/dbus/zbus/-/blob/main/zbus/src/quick_xml.rs#L352) a sample xml...

Consider using zbus instead of dbus for easy cross compliation

> If there is still interest in PRs switching from dbus to zbus, I'd be happy to start working on them :) Pretty sure there is (right @surban?) but tbh...

Consider using zbus instead of dbus for easy cross compliation

wow @wash2 wasn't messing around. Thanks to them, git main of zbus now supports fallible property getters. @surban There is a small gotcha that currently you can only return [`fdo::Error`](https://docs.rs/zbus/latest/zbus/fdo/enum.Error.html)...

Consider using zbus instead of dbus for easy cross compliation

just FYI I publish zbus 3.10.0 which includes the needed feature.

Consider using zbus instead of dbus for easy cross compliation

@wash2 How is it coming along? Please do let me know if you need any help figuring out the zbus API for this. In case you didn't know already, we've...

Consider using zbus instead of dbus for easy cross compliation

> but I'm worried that I won't be able to test everything that I'm changing sweat_smile Let's hope @surban can help with that part. Maybe a Draft PR first? >...

Consider using zbus instead of dbus for easy cross compliation

@Athorus I think it's just waiting on someone to do the work.

gets confused by sd-bus clients pipelining the SASL handshake

Just FYI, zbus started pipelining the handshake in its latest releases (4.1.2 and 4.2) and this means zbus flatpak apps breaking. Seems @mardy already provided a fix a month ago...