zbus-old icon indicating copy to clipboard operation
zbus-old copied to clipboard

Published 20 hours ago • verified publisher icon dbus2

Generate 'emits_changed_signal' property - [opened]

Open zeenix opened this issue 2 years ago • 6 comments
trafficstars

In GitLab by @RDruon on Feb 17, 2023, 16:34

Merges emits_changed_signal -> main

Generate #[dbus_proxy(property(emits_changed_signal = "$VALUE"))]/#[dbus_proxy(property(emits_changed_signal = "$VALUE"), name = "$NAME")] based on annotations value.

zeenix avatar Feb 17 '23 15:02 zeenix

Why create a new PR for the same exact thing? :thinking: You know you can just force push your completely new changes to the same branch, right?

zeenix avatar Feb 17 '23 17:02 zeenix

Please rebase on latest main for fixing the CI.

zeenix avatar Feb 18 '23 18:02 zeenix

In GitLab by @RDruon on Feb 20, 2023, 09:00

Sorry about that, I messed up the fork and wasn't able to push on the same PR

zeenix avatar Feb 20 '23 08:02 zeenix

In GitLab by @RDruon on Feb 20, 2023, 09:01

added 8 commits

  • 24e52965...396d65ab - 7 commits from branch dbus:main
  • 9f9e8ad2 - Generate 'emits_changed_signal' property

Compare with previous version

zeenix avatar Feb 20 '23 08:02 zeenix

resolved all threads

zeenix avatar Feb 20 '23 13:02 zeenix

  • Without updates to the tests and/or docs, it's a bit hard to tell what this PR does.
  • Also the PR description isn't very clear to me. Could you please expand a bit there.
  • Also, please always add description(s) to commit log(s) too.

zeenix avatar Feb 20 '23 14:02 zeenix