Hiroaki Yutani

Thanks for the suggestion, but this doesn't sound convincing to me. The problem of this example looks the width of each bar, rather than the alignment? (not sure if the...

Ah, sorry, I didn't get your point. So, is this the plot you want to draw? ``` r library(ggplot2) library(dplyr, warn.conflicts = FALSE) library(lubridate, warn.conflicts = FALSE) df summarise(value =...

Thanks, I think your calculation is correct. I agree it might make sense.

Yes, I'm happy to review. I too feel the implementation won't be very complicated. One thing I'd like to discuss here is the interface. In my opinion, `hjust` is better...

Thanks, I'll need to modify the expectations here... https://github.com/tidyverse/ggplot2/blob/18be30e1515b2b9d05ade4f3f2b5051aa1336fcf/tests/testthat/test-annotate.r#L33-L51

I feel * `annotation_custom()`, `anotation_raster()`, and `annotation_map()` should be modified to have data. * `annotation_logstick()` can be kept as is.

Thanks, let me think how to test it...

@thomasp85 Sorry, I didn't get your point. What do you mean by "annotations doesn't affect the scales of the plot"? I think annotations does affect. ``` r library(ggplot2) library(patchwork) p

Opps, I got it. That's the very reason we needed different annotations than `annotate()`. Sorry, I didn't understand this. https://github.com/tidyverse/ggplot2/blob/7bafc45d4db081341f3fcca61932d0efd3a2fd43/R/annotation-custom.r#L6-L10 So, by their definitions ("the grob will not be modified...

Sure. One possible choice is to transform data in `draw_layer()` because there are scales in `layout` and `data` with `xmin`, `xmax`, `ymin`, and `ymax`, mapped by `Layer$compute_geom_2()`. https://github.com/yutannihilation/ggplot2/commit/092f39f7e83280540e271fdd112e0347fff605da But, it...