Hiroaki Yutani

Results 319 comments of Hiroaki Yutani

It seems the link cannot be opened without a ycombinator account. What does it say?

Thanks, it works now.

When the `fill` columns get dropped in all the groups, it's captured by this logic introduced in #4866. But, when there's any undropped one, it fails to capture. https://github.com/tidyverse/ggplot2/blob/a979ffd26cdb456d54e2671c2eed16c65bc878b7/R/stat-.r#L135-L145 ```...

@clauswilke > Is the issue that aesthetics gets dropped on a per-group basis, and so it can happen that they get dropped only for some groups? Yes. > If I...

I made another pull request https://github.com/tidyverse/ggplot2/issues/4394. Now it gives the following result. ``` r devtools::load_all("~/GitHub/ggplot2/") #> ℹ Loading ggplot2 d Warning: The following aesthetics were dropped during statistical transformation: fill...

Copying @baderstine's comment from https://github.com/tidyverse/ggplot2/issues/3834#issuecomment-1165825262, which describes why the combination of `theme(aspect.ratio = )` and `facet_grid(space = "free")` was useful. On #3834, we came to the conclusion the combination is...

Thanks. it seems jitter calculates `-Inf` for `-Inf` value, accordingly, `-Inf - (-Inf)` results in `NaN`. We can check if the value is infinite and skip jittering. https://github.com/tidyverse/ggplot2/blob/ae7fb41d33fd629cddbea484fc37b5f02dea3c41/R/position-jitter.r#L87-L89