Hiroaki Yutani

Results 319 comments of Hiroaki Yutani

Oh, thanks. So, is this still something that needs to be resolved on scales' side? Anyway it seems we are getting closer!

It seems this existing code will be broken by this change. I'm still thinking, but this might mean the same case can be found with `stat_bin()` and `stat_count()`...? ``` r...

Thanks. Yes, I'm almost giving up this pull request. Rather, my current concern is if `stat_bin()` and `stat_count()` might be also wrong. The below example won't work even if I...

As this pull request seems impossible, I'm giving up this. Sorry that I didn't come up with the usage.

I like the idea. One more thing to consider is how to handle `make_sec_title()`. I think we can just assign the same as `make_title()`. https://github.com/tidyverse/ggplot2/blob/37eb64de719c6f60c9f467f5530d59d2a477ee07/R/scale-.r#L515-L517

> Is that for the second axis, if there is one? Yes, I guess so, but I too don't know well about the Scale-related things. Honestly, I have no idea...

When you specify a column inside `aes()`, the values are scaled and mapped to a color map, and when outside they aren't. This sort of question is a better fit...

Ah, sorry I missed your point. I think you are right, but I believe passing multiple values outside `aes()` is not a recommended usage anyway. > As far as I...

Thanks, I think we all are agreeing on this option (I'd like to implement this as a general one, not limited to `geom_dotplot()`, not limited to `colour` or `fill`). >...