Hiroaki Yutani

Results 319 comments of Hiroaki Yutani

As `scale_colour_discrete()` is the default discrete colour scale, the document shows what the user can do on the default scale. I don't think the documentation is bad. But, it might...

I think this is a good idea, but the problem is that ggplot2 doesn't include any of the actual method implementation. So, I'm afraid this is difficult to do within...

Thanks. So, maybe `position_dodge2()` should raise an error when `width

@javlon Sorry, it was my fault that I didn't notice the issue. Thanks for catching. Could you just revert the change in a different PR (hopefully with a test, but...

I'm against. I believe this should be solved by double dispatch, not by avoiding double dispatch. As I commented on #3815, it's possible even with the current ggplot2 if you...

I meant `ggplot_add()` should have been implemented to support double dispatch. > I can not upgrade my object to be S4 without breaking my downstream dependencies. Can we see some...

> Off-hand, I believe `plotly` would break. Link of accessing `p$nrow` and `p$ncol` (and other `p$*` values) Aw, I see... Thanks for the example.

Let me clarify my stance on this pull request. Honestly, I'm not very happy that we are about to end up with exposing both `add_ggplot()` and `ggplot_add()`, which will probably...

> later with R7. Just to be sure, "later" means "at least a few years away" (c.f. ). I thought it would be a bit too far, so my take...

A kind of related: https://github.com/tidyverse/ggplot2/issues/4014