Hiroaki Yutani

Results 319 comments of Hiroaki Yutani

> most of the time it works, and sometimes it doesn't, and sometimes it actually solves a real problem I don't remember well, but I get this point. However, I...

Thanks, confirmed. Currently, the `title` of `guide` is referenced only by `CoordCartesian$label()` via `panel_guide_label()`: https://github.com/tidyverse/ggplot2/blob/d3d47be055055ebf328aeed0bebb990a635c49ab/R/coord-cartesian-.r#L154-L173 https://github.com/tidyverse/ggplot2/blob/d3d47be055055ebf328aeed0bebb990a635c49ab/R/coord-cartesian-.r#L217-L220 The other `Coord` classes use the inherited `Coord$label()`: https://github.com/tidyverse/ggplot2/blob/d3d47be055055ebf328aeed0bebb990a635c49ab/R/coord-.r#L62 But, it seems we cannot...

Thanks, then let me try a PR this time. This would be a nice lesson to get familiar with coords and guides (and even if I fail, the experience should...

`coord_trans()` was fixed by #3972. `coord_polar()` (and other coords) stays the same.

As [the previous comment on the pull request](https://github.com/tidyverse/ggplot2/issues/4341#issuecomment-774492527) says it would be "for the next big ggplot2 release," I too thought so.

Can we add https://github.com/tidyverse/ggplot2/pull/3818 to the milestones? While I'm honestly not happy with the consequence of exposing both `add_ggplot()` and `ggplot_add()`, which looks confusing, I think we should merge the...

Ah, okay. Since hadley agreed on the direction (https://github.com/tidyverse/ggplot2/pull/3818#issuecomment-1076435320, and https://github.com/tidyverse/ggplot2/issues/4743#issuecomment-1066978477) and no one has raised objections so far, I thought it was the decision. Let's discuss there if needed.

Thanks, I added two. * I'd like to include #4917 if possible, not because it's related to #4866, but because it's a breaking change. I'm not sure if we can...

I found #3816 could be the one that the next release is the good timing to release, but it might be a bit too late...

I added https://github.com/tidyverse/ggplot2/issues/4953 to the milestone because this is probably what we should decide before releasing `linewidth`.