Yacin Tmimi

Results 716 comments of Yacin Tmimi

@otiv-emiel-vanseveren thanks for the report. I'm personally not familiar with bazel. Is this issue reproducible without using bazel? Also, Do you have a repo you can link to that can...

Will probably be a little while before I'm able to review this, but I wanted to note that there's a semi related PR (https://github.com/rust-lang/rustfmt/pull/6149) that adds a new option to...

The git history seems off to me. I think you might have squashed too many commits or grabbed the wrong commit message somehow?

@vats004 Sure! You can create a nearly identical PR. The only difference is that we'll need to gate this change on `StyleEdition::Edition2027`, instead of `Version::Two`.

> What's the rationale for gating a clear bugfix behind a future edition? rustfmt has a strong stability guarantee

Closing since #6572 was merged instead

Thanks for the report! I think this is the same issue that was discussed in https://github.com/rust-lang/rustfmt/pull/6149#discussion_r1569703726

I took a quick look at the [dirs README](https://github.com/dirs-dev/dirs-rs/blob/main/README.md#features) and the [dirs code](https://github.com/dirs-dev/dirs-rs/blob/50b50f31f3363b7656e5e63b3fa1060217cbc844/src/lin.rs#L9), and both seem to suggest that `XDG_CONFIG_HOME` is already supported by dirs.

Oh wait, that's just for linux. Reopening.

@heygarrett we've had issues in the past where users have reported configs not being loaded properly. To avoid any breakage due to the proposed switch to `etcetera` I think we'll...