Yacin Tmimi comments

Results 716 comments of


                                            Yacin Tmimi

Dioxius macros confuse rustfmt

@uzytkownik it's been a while since I've heard from you on this, and I'm still unable to reproduce the error so I'm going to close this.

Formatting of consecutive vec! lines requires multiple runs

Thanks for the report. The indentation on the second `vec![]` looks off to me too.

Comment indentation on opening line of a block is incorrect

Tough to say how much things have diverged for this change in particular, but we might get lucky and it could be a simple cherry-pick of the commits to a...

Comments placed in-between a field and type in a struct get deleted after formatting

Simliar to #5464, but the comment is after the `:`

Wish to have some new options about line break style

Seems like this is related to #3626 and is the opposite of #3514

`format_strings` can cause code to no longer be reformatted

Thanks for the report. When you're enabling `format_strings=true` are you applying that config to the diffed code output or the original input? It wasn't totally clear to me based on...

`format_strings` can cause code to no longer be reformatted

Also, is this only an issue for `style_edition=2024` or do you see the same results with `style_edition={2015| 2018 | 2021}`?

`format_strings` can cause code to no longer be reformatted

> but before upgrading to edition 2024 nightly and stable rustfmt agreed. Assuming you weren't setting any nightly only configuration options then it makes sense that `nightly` and `stable` would...

Add config and attribute to set the number of array values per line

related to #5553

silently fails to format match expression if arm pat contains comment

@daprilik you can set `error_on_unformatted = true`. Trying to format the code snippet from https://github.com/rust-lang/rustfmt/issues/4119#issuecomment-1400933562 produces the following warning: ``` error[internal]: not formatted because a comment would be lost -->...