Yacin Tmimi comments

Results 716 comments of


                                            Yacin Tmimi

Special case `matches!` macro

> Sorry for the bump, but there hasn't been any public news on this for almost a year now. Have there been any discussions or anything about whether to include...

--print-config current with use_small_heuristics = "Off": Could not output config: out-of-range value for u64 type

@antifuchs thanks for the report. What version of rustfmt are you using? Also, are all of these configs relevant to reproduce the error? Can you make the reproducible test case...

rustfmt hangs indefinitely parsing large decimal literals and deep parentheses

Thanks for the report. What version of rustfmt are you using? Can you run `rustfmt --version`?

Enhance diff_check with more unicode et al

@calebcartwright I don't think the use of `cargo make` on any project we test would be an issue. The diff check job just runs rustfmt againsg all `.rs` files it...

Enhance diff_check with more unicode et al

@calebcartwright good point. I guess if we landed support for `cargo fmt` to be passed individual files then that would mostly solve the `edition` issue. I'm nearly 100% sure `style_edition`...

Enhance diff_check with more unicode et al

@rufevean yeah this one is still open

Enhance diff_check with more unicode et al

it's unclear what the issue is here. Are you able to run the script on your machine without adding those new repos?

Enhance diff_check with more unicode et al

[Line 148 is where we try to get the version value for the feature binary](https://github.com/rust-lang/rustfmt/blob/6157568e1cec55ce6df09342ba0ae9686dec99c9/ci/check_diff.sh#L148). Not sure why adding those lines would cause an issue there. The error message suggests...

[unstable option] condense_wildcard_suffixes

The documentation demonstrates that when set to `false` rustfmt won't perform the transformation from `(_, _, _) -> (..)`. If the user writes `(..)` in their code rustfmt won't change...