Yacin Tmimi comments

Results 716 comments of


                                            Yacin Tmimi

Encountered cargo fmt ICE when writing complicated match statements with field names containing greek letters and trailing space after comma

You said the code snippet was thousands of lines long, meaning that there's a ton of extra code in there that's unrelated to the issue. I'm looking for a well...

Encountered cargo fmt ICE when writing complicated match statements with field names containing greek letters and trailing space after comma

Thank you. I can confirm that with `rustfmt +1.85` I can reproduce the error, but I think this has been resolved in source (https://github.com/rust-lang/rustfmt/pull/6391), because when I build and run...

Internal error when trying to format code with inline block comment

@Sorseg linking to the file is definitely useful. When you get a chance could you try to create a minimal test case that someone could use to reproduce the issue.

Internal error when trying to format code with inline block comment

If you set `error_on_unformatted = true` you'll get some additional information about why this failed to format. The issue here is that rustfmt isn't expecting to find a comment between...

Internal error when trying to format code with inline block comment

I believe we'd need to make adjustments in the `Rewrite for PatField` impl to address this, though my current recommendation would be to not write comments within struct fields: https://github.com/rust-lang/rustfmt/blob/e4944185ae09c99f59b460e358909f329010ea9c/src/patterns.rs#L385-L433

rustfmt forcefully moves trailing comments to irrelevant code above (and not idempotent either)

@msrd0 thanks for the report. What version of rustfmt are you using?

rustfmt forcefully moves trailing comments to irrelevant code above (and not idempotent either)

I believe this is related to https://github.com/rust-lang/rustfmt/issues/4757

`wrap_comments` sometimes breaks code blocks in lists

Thanks for reaching out. This is a limitation of how rustfmt handles markdown. rustfmt has an extremely basic understanding of markdown constructs like headers, lists, blockquotes, and code blocks. Once...

`wrap_comments` sometimes breaks code blocks in lists

Linking tracking issue for `wrap_comments` (#3347)

Group imports together with imports_granularity results in non-idempotent formatting

Linking the tracking issue for `group_imports` (#5083) and `imports_granularity` (#4991)