Yacin Tmimi

Results 716 comments of Yacin Tmimi

Maybe we need to extend `inline_attribute_width` (https://github.com/rust-lang/rustfmt/issues/3343) to also apply to function parameters?

rustfmt can't change default formatting because of it's stability guarantee. Breaking changes can only be made [if they're gated](https://github.com/rust-lang/rustfmt/blob/master/Contributing.md#gate-formatting-changes).

Any change to leverage `inline_attribute_width` would need to be gated since the default value for the option is `0`, which would force the wrapping behavior that you're looking for.

seems related to #3716

Thanks for reaching out. Confirming I can reproduce this with `rustfmt 1.6.0-nightly (e480739e 2023-08-17)`. **output `using version=0ne`** ```rust type AAAAAAAAAAAAA: BBBBBBBBBBBBBBB< CCCCCCCCCCCCCCCCC, DDDDDDDDDDDDDDDDD, EEEEEEEEEEEEEEEEE, FFFFFFFFFFFFFFFFF, GGGGGGGGGGGGGGGGG, HHHHHHHHHHHHHHHHH, IIIIIIIIIIIIIIIII, >; ```...

@johnhuichen I don't think we need to move the bound definition to the next line. My guess is that this is a `Shape` related issue. `Shape` is the type we...

@johnhuichen Thanks for continuing to look into this. To figure out how to proceed I've been looking throught the [Rust Style Guide](https://doc.rust-lang.org/nightly/style-guide/index.html). The trait formatting looks right to me, and...

> just checking for a status on this one, what's pending? For me, I'd like to confirm the formatting for the extra test cases mentioned in https://github.com/rust-lang/rustfmt/pull/6305#discussion_r1779739121. Assuming those get...

No outstanding questions besides my last two comments. * https://github.com/rust-lang/rustfmt/pull/6305#discussion_r1779739121 * https://github.com/rust-lang/rustfmt/pull/6305#issuecomment-2429857947

@TomFryersMidsummer thanks fort the report. What version of rustfmt are you using? How are you calling rustfmt in your scripts? Do you have a `rustfmt.toml` file in the project? have...