Yacin Tmimi

Results 716 comments of Yacin Tmimi

@utkarshgupta137 Thanks for continuing to help review this and for checking up on various test cases. > Will probably be useful to add a $pub which covers pub(crate) & pub...

@l4l thanks for reaching out! I wouldn't say this has been forgotten, it's just been put on the back burner while we tend to some higher priority items. We spent...

@dcow I'd suggest that you open up a new issue to fully describe the problem that you're experiencing

I think the issue here is that the inner attributes are stored on the outer [`ast::Expr`](https://doc.rust-lang.org/beta/nightly-rustc/rustc_ast/ast/struct.Expr.html) node with the `kind` of [`ast::ExprKind::ConstBlock(AnonConst)`](https://doc.rust-lang.org/beta/nightly-rustc/rustc_ast/ast/enum.ExprKind.html#variant.ConstBlock). Internally the [`ast::AnonConst`](https://doc.rust-lang.org/beta/nightly-rustc/rustc_ast/ast/struct.AnonConst.html) holds a reference to an...

Thanks for the report. This feels like it's related to #5738. Here's a smaller reproducible test case: ```rust enum MZReaderType< D: DeconvolutedCentroidLike + Default + From + BuildFromArrayMap=DeconvolutedPeak > {}...

@iddm There are no updates to share at the moment. PRs are welcome!

@calebcartwright I think we need to remove or disable the [`generic-simd`](https://github.com/rust-lang/rustfmt/blob/728939191e4218e2c1296c7ba3eb36590cbcb9bd/Cargo.toml#L33) feature. [bytecount](https://github.com/llogiq/bytecount) uses [packed_simd](https://github.com/rust-lang/packed_simd), which is where the [error is occurring](https://github.com/rust-lang/packed_simd/issues/360) on our nightly builds.

Yeah, I thought I'd take a stab at resolving the issue in https://github.com/llogiq/bytecount/pull/92. CI is passing so I'm guessing I ported things over from `packed_simd` to `std::simd` correctly. Depending on...

Works for me. Hopefully the `bytecount` maintainers can help get the upstream PR reviewed soon🤞🏼

@calebcartwright `bytecount` pushed a new minor release with fixes for `generic-simd` 🎉