Yacin Tmimi

Results 716 comments of Yacin Tmimi

Yeah, I think you're right. I'm pretty sure we don't handle the new [ast::AssocItemKind::Delegation](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_ast/ast/enum.AssocItemKind.html) variant.

Pretty sure this is where we hit the panic!: https://github.com/rust-lang/rustfmt/blob/bf967319e258acb9b1648a952bba52665eceaf52/src/visitor.rs#L632-L671 We'll likely need to wait until the next subtree sync before a fix can be released for this

Thanks for the report. I'm pretty sure that this is a duplicate of #6022

@calebcartwright want me to add entries for these PRs too? * #5971 * #5582 * #6034 * #6073 * #6101 * #6085 * #6092 * #6112

@calebcartwright this should be ready to go, and I added entries for the outstanding changes that have been merged.

@calebcartwright I made some changes. Take a look when you get a chance.

Thanks for the report. I just took a quick look at this. rustfmt isn't expecting to find comments between the opening paren and the start of the pattern. Also, rustfmt...

I don't know how much it would complicate the parser to have it also output comment spans. We've had some recent conversations about it in our team meetings, and I...

Thanks for your first contribution to rustfmt 🎉 when you have a moment, could you expand on why the change implemented here addresses the panic in `annotated_snippet`. I want to...

The issue here is that `rewrite_struct_pat` doesn't have any comment recovery code defined for trailing comments after the `..`. rustfmt errs on the side of caution here and refuses to...