Yacin Tmimi
Yacin Tmimi
@calebcartwright I think this might have more to do with how we handle [`CommentStyle::Custom`](https://github.com/rust-lang/rustfmt/blob/d5f1200ed6a8e375f963e0c59a8bee45c0018c55/src/comment.rs#L49) comments. The following input isn't formatted strangely. **input** ```rust fn main() { f(0, 1,); // f()...
@calebcartwright @matthiaskrgr looking through the issue tracker this seems like a duplicate of #5391 and #5868
Thanks for applying the feedback. Can you squash all of these into a single commit when you get a chance.
Running our [Diff Check Job](https://github.com/rust-lang/rustfmt/actions/runs/9166837698/attempts/1), and assuming this passes we'll be good to go here
🤔 hmmm the job failed when comparing the output from current HEAD (rustfmt 1.7.0-nightly (d5f1200 2024-05-01)) and your latest commit (rustfmt 1.7.0-nightly (54dfcef 2024-05-02)). Surprisingly, compiling both versions of rustfmt...
I think this might just be an issue with the CI job, but I'll need some more time to look into it
Seems like it was a temporary CI issue, but now [the job is passing](https://github.com/rust-lang/rustfmt/actions/runs/9318871734/job/25652104702). Thanks again for your help on this!
I haven't reviewed the code yet, but I took a quick look at the test cases. When you have a moment can you add a test case where there's more...
> Yeah that diff number made my eyes pop out like a cartoon character. At first blush it definitely feels too big to try to do in one pass, so...
Hey @tgross35, I haven't put more work into this PR, but I've recently been trying to expand on what I've got here in https://github.com/ytmimi/markdown-fmt. Feel free to take a look!