Yacin Tmimi

Results 716 comments of Yacin Tmimi

Thanks for updating the snippet. I'm now able to reproduce the issue with `rustfmt 1.5.1-stable (90743e72 2023-01-10)` **Input** ```rust #[derive( Serialize, Deserialize, Debug, Clone, EnumString, EnumIter, strum_macros::Display, PartialEq, Eq, )]...

@IVIURRAY this one seems similar to the issue you just worked on. It's possible that your fix might have resolve this. Would you be able to check if this is...

@IVIURRAY correct! I believe the expectation is that ```rust #[derive( Serialize, Deserialize, Debug, Clone, EnumString, EnumIter, strum_macros::Display, PartialEq, Eq, )] #[serde(rename_all = "snake_case")] pub enum Action { Create, Update, Delete,...

@IVIURRAY thanks for looking into this. I'd be surprised if we needed to make changes to the list formatting code in order to solve this, but maybe it's possible 🤷....

> ```rust > use { > super::harriblex, > super::harriblex::{ > Iraquant, > Mediviction > }, > }; > ``` > > should be merged to: > > ```rust > use...

I still need to take another look at this one. After I understood what the `max_depth` changes were doing I questioned whether or not `a.equal_except_alias(b)` was the right comparison to...

will take another pass at this when I have some time. In the meantime take a look at the next round of comments I left.

seems related to changes made in https://github.com/rust-lang/rustfmt/pull/5883. probably need to go back and update the logic to take incomplete matchers into account.