Yacin Tmimi

Results 716 comments of Yacin Tmimi

@compiler-errors thank you for the detailed explanation and for jumping into action so quickly on this one 🙏🏼

Just checked and `nightly-2024-01-23` restored the formatting. ```bash rustfmt +nightly-2024-01-23

Just getting back around to this now as I'm going through the backlog. I kicked off the [Diff-Check](https://github.com/rust-lang/rustfmt/actions/runs/7689539651). Edit: The job ran without any errors ✅

cc: @rust-lang/style Would love some feedback on this to make sure that my ideas for how to implement `style_edition` line up with your expectations for the design laid out in...

> One thing that would be good to document explicitly: is it OK for some formatting to just directly look at the style edition, rather than requiring a configuration option...

It's bee a very long time since I've looked at this, but I'm pretty sure I meant `rustfmt.toml` since rustfmt doesn't use `Cargo.toml` for any of its configurations. That being...

@spectria-limina Thanks for reaching out. I'm having trouble reproducing the trailing comma issue that you've described. Are there maybe other configuration options that you're using? [`merge_derives=true`](https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#merge_derives) is configured by default....

@Dzordzu Thanks for reaching out. Without a minimal reproducible code snippet that we can use to reproduce the issue there's not action that the rustfmt team can take. When you...

@Dzordzu thanks for following up. What version of rustfmt are you using? When running `rustfmt 1.5.2-nightly (2d0aa576 2023-06-18)` on your input snippet I'm unable to reproduce the internal error that...

@Dzordzu I'm unable to reproduce the described behavior with the new snippet either. Can you confirm what version of rustfmt you're using and enumerate any non default configs you might...