Pierre Yger

Results 199 comments of Pierre Yger

I have a proposal, but would need approval before trying to implement it everywhere. Why not using the python [logging](https://docs.python.org/3/library/logging.html) module? I've made a test here in the branch, and...

Ok cool, let's wait for some more feedback before I'll do the big dive. The plus: - it will help to structure all logs - no extra dependencies - have...

Other options would be to allow having multiple loggers, and instead of removing the "verbose" argument, provide some way for all function requesting logging to select which logger to use....

Yes, of course there will be a default one in SI. Up to us to decide if we will log to screen/file, and what is the logging level. The problem...

Indeed, there is a draft of such a refactoring. Currently, the node pipeline is loading all the chunks, even if there are no peaks in it. This should and will...

It has been merged, now computations are only done when you have spikes. So it can be closed

Lots of file are changed, but this is only to extend the syntax of the NoiseGeneratorRecording, with noise_levelS instead of noise_level. This makes more sense to me I think

Ok, good to know, if all the arguments/inputs are also saved, then perfect. As said, I want the dump to be self-contained, so as @alejoe91 is saying with motion signals....

Some questions remain. When we do a merge, do we want to add the possibility to remove spikes that would violate some refractory period? If this, this might make evertyhing...

Indeed, I could have use the merge sorting object. We'll see. But based from discussions with @samuelgarcia , my understanding was that it was much faster to work at the...