Pierre Yger comments

Results 199 comments of


                                            Pierre Yger

Proposal to implement a sorting_analyzer.merge_units() syntax

Looks like something is strange with the diff here. Too many files are marked as modified...

Proposal to implement a sorting_analyzer.merge_units() syntax

This is now ready to read, and the run times are now mucchh better (they were really slow with the waveforms/pca) @samuelgarcia @alejoe91 the only question that remains is if...

Proposal to implement a sorting_analyzer.merge_units() syntax

ok camarade

Proposal to implement a sorting_analyzer.merge_units() syntax

Indeed, we should add more tests, I'll try to make some more. This would be great to test all extensions. And about documentation, where should it go?

Handling torch params globally with set_global_torch_kwargs ?

One other option would be to add torch_device in job_kwargs, and have mutiple options (None (no torch), "auto", "cpu", "gpu"). The good point about that is that we do not...

Matched filtering with both peak signs simultaneously

This PR should not be merged as it is, because even if this is working without error, the behavior is strange. I suspect that, in the numba kernel, there is...

Matched filtering with both peak signs simultaneously

@samuelgarcia I've found the bug and I've patched it. This is maybe too late for the release, but since it was tagged at some point. Now this branch is working...

Matched filtering with both peak signs simultaneously

@samuelgarcia I've added the optimisation we discussed for convolution in this PR, and this is ready to go on my side

Benchmarks components: plotting utils

Fine for squashing and merging

spykingcircus2 Insufficient system resources exist to complete the requested service

Can you launch the sorter with the option verbose=True, to get a better sense on where it is crashing? This is strange because SC2 can now work with 4096 channels,...