Pierre Yger comments

Results 199 comments of


                                            Pierre Yger

Extracting traces in parallel to speed up get_noise_levels (or any other traces related functions)

This has been done in #3359 . Can be closed

Simplification of signatures wrt noise_levels

Current, noise levels are already treated as a "special" property, since they are cached and used as a private attribute. So to me, this is making the whole API more...

Patch to skip chunks without peaks or if enough peaks have been detected

Ok, so what should be done is simply checking if the first node is a PeakSource, and it it has spikes, then load traces otherwise skip. I'll give it a...

Patch to skip chunks without peaks or if enough peaks have been detected

Here we go, let me know if this works with the node_pipeline spirit!

Patch to skip chunks without peaks or if enough peaks have been detected

I've extended the PR to cases where we want to stop everything when at least max_peaks have been discovered. This is working, and to allow shuffliung of the chunks, we...

Patch to skip chunks without peaks or if enough peaks have been detected

Yes, @samuelgarcia wants to redesign something, so I guess this will be postponed

Patch to skip chunks without peaks or if enough peaks have been detected

This has been done in #3356

get_chunk_with_margin() should accept return_scaled

Hum... I did not consider such a problem. I'll keep thinking about it, but if no better solution, then what you are suggesting is indeed the way to proceed. If...

get_chunk_with_margin() should accept return_scaled

Actually, new proposal before discussion. Since the problem is only in the run_node_pipeline, mostly used in components, then maybe in the node pipeline, when we want to access the (final,...

Could we reuse plotting function made for WaveformExtractor for Templates

Actully, I think that to be consistent, the get_all_templates() function of the waveform_extractor should return a Template object, don't you think?