spikeinterface icon indicating copy to clipboard operation
spikeinterface copied to clipboard

extension `spike_amplitudes` is really slow with few spikes

Open DradeAW opened this issue 1 year ago • 2 comments

analyzer.compute("spike_amplitudes") is really slow (90s in my case) even when the sorting contains a single unit with two spikes.

Chunks of recording with no spikes should be skipped.

DradeAW avatar Mar 07 '24 11:03 DradeAW

Yes I know. I will do it soon. the node piepline need some refactoring for scaling and this. pierre already worked on this but I need to refactored a bit and the main was frozen but SortingAnlyzer for long time.

note that the number of units do not impact the time but more the time to load traces from the entire file.

samuelgarcia avatar Mar 07 '24 11:03 samuelgarcia

Indeed, there is a draft of such a refactoring. Currently, the node pipeline is loading all the chunks, even if there are no peaks in it. This should and will be modified soon, but as @samuelgarcia mentionned, the big refactoring of the SortingAnalyzer perturbed everything. We will keep yo updated

yger avatar Mar 11 '24 09:03 yger

@samuelgarcia @yger are we good here? I was following you guys trying to skip stuff, but I forget if that ever got merged?

zm711 avatar Nov 22 '24 19:11 zm711

It has been merged, now computations are only done when you have spikes. So it can be closed

yger avatar Nov 22 '24 19:11 yger