Yasuo Honda comments

Results 167 comments of


                                            Yasuo Honda

Set charset name utf8mb4 by default

MySQL 8.0.29 reports warnings for `utf8` character set. https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-29.html > Character Set Support > > Important Note: The server now uses utf8mb3 rather than utf8 in the following cases: >...

OracleEnhancedAdapter.emulate_booleans doesn't work

I am happy to review pull requests with tests. https://github.com/rsim/oracle-enhanced/pull/2199 aims to reduce amount of memory in Rails 7.0. So converting the TYPE_MAP into constant may introduce the same memory...

Use default_sequence_name to identify sequence when rename a table

Thank you for opening a pull request. Would you add some specs for this change?

CHAR should return nil for NULL values in column

Thanks for opening a pull request. Would you add some specs? Unfortunately, ActiveRecord Oracle enhanced adapter 6.1.z and 6.0.z are not actively maintained so no back port will be done.

Include check constraints in structure.sql

CI failures are likely due to missing support https://github.com/rails/rails/commit/d79fb963603658117fd1d639976c375ea2a8ada3 . Now https://github.com/rsim/oracle-enhanced/pull/2199 is opened but it needs to fix some other failures.

Include check constraints in structure.sql

I'd like to resolve https://github.com/rsim/oracle-enhanced/pull/2199 first to merge other pull requests.

Include check constraints in structure.sql

Now #2199 has been merged to master branch, Would you rebase this pull request?

Include check constraints in structure.sql

This pull request needs updated not to fail this spec. ```ruby $ bundle exec rspec ./spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:219 ==> Loading config from ENV or use default ==> Running specs with ruby version...

Optional identity columns

Let me have some review.

raw type should be able to deserialize

Related to https://github.com/rails/rails/issues/44317