Yasuo Honda

Results 167 comments of Yasuo Honda

I overlooked the CI failure. Please address this error as suggested and squash your commits. ```ruby % ARCONN=postgresql bin/test test/cases/adapters/postgresql/extension_migration_test.rb -n test_enable_extension_migration_with_schema Using postgresql Run options: -n test_enable_extension_migration_with_schema --seed 3125...

After thinking about this pull request for some time, I have decided to merge this pull request. Thanks for the contribution.

Would you consider to add https://github.com/pingcap/tidb/issues/32118 to this list? I think it needs supported because it blocks using MySQL Connector/J 8.

I'm closing this pull request mainly because creating custom collations is not required for many users. If someone needs it, custom collations can be created via raw SQL statements as...

I think the current implementation is fine and the error message "no block given (yield) " is straighforward. This error is generated by Ruby and users are easy to find...

Could you address the RuboCop offense below and squash commits? > activerecord/test/cases/adapters/postgresql/extension_migration_test.rb:65:1: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.

Let me clarify my point. Rails migration task allows changing multiple schema objects. Therefore, we cannot change the advisory lock scope to per schema by default. I understand there are...

I've found `last_insert_id()` behavior differences between MySQL 5.7 and 8.0. TiDB 6.6.0 behaves same as MySQL 5.7. #42084

It looks like TiDB does not support this feature available since MySQL 8.0.13 yet. This checkbox is checked somehow. Default values for BLOB/TEXT + default value as function (8.0.13) https://github.com/pingcap/tidb/issues/10377...

It is not a big deal though `utf8mb4_0900_bin` collation has been introduced since MySQL 8.0.17. Here it is listed as "8.0.11 and before" https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-17.html https://github.com/mysql/mysql-server/commit/c7934d119aeb