Yasuo Honda

Thanks for the explanation. Now I understand two integers are necessary, one for database and another one for the schema. Now I'm taking a look at the code and I...

I am thinking that if `generate_migrator_advisory_lock_id` or `db_name_hash` inside the `generate_migrator_advisory_lock_id` can be overwritten cleanly by the connection adapters or something, it may satisfy the apartment specific requirement and Rails...

As far as I understand, apartment gem has its own connection adapters for each database, https://github.com/rails-on-services/apartment/blob/development/lib/apartment/adapters/postgresql_adapter.rb Just moving `generate_advisory_lock_id` method to the connection adapters may be enough? I have pushed...

It is intentional that https://github.com/rails/rails/compare/main...yahonda:rails:another_advisory_lock does not change any advisory logic for PostgreSQL adapter. This commit just moves `generate_advisory_lock_id` method from `ActiveRecord::Migration` to `ActiveRecord::ConnectionAdapters::AbstractAdapter` and its children `ActiveRecord::ConnectionAdapters::PostgreSQLAdapter` and `ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter`....

This test case successfully finishes by adding `self.primary_key = "rx_number"` to each model. ```ruby class Prescription < ActiveRecord::Base self.primary_key = "rx_number" has_many :fills, foreign_key: :rx_number, primary_key: :rx_number end class Fill...

These method definitions provides the enogh information. IMO, So I do not thik we need to provide the version information as comments. https://github.com/rails/rails/blob/9994d38bc6c1a8662e510d26c0e9ca8c24ab1189/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb#L125-L131 https://github.com/rails/rails/blob/9994d38bc6c1a8662e510d26c0e9ca8c24ab1189/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb#L418-L420 https://github.com/rails/rails/blob/9994d38bc6c1a8662e510d26c0e9ca8c24ab1189/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L158-L160

Thanks for the comment. As far as I understand, the comment previously added via https://github.com/rails/rails/commit/3c7e190ee8e3474e4ddf00ae0ac3a7c21d6f3d41 to clarify because Rails CI used to run MySQL 8.0 which supports CTE and did...

I'd like to know if this requirement can be achived by setting `{ case_sensitive: false }` to the uniqueness validator as follows. - User model ```ruby class User < ApplicationRecord...

Thanks for the explanation. I understand there are some cases that database level validation is necessary. Still, I'm not inclined to implement `create_collation` related migrations because although this change is...

We don't take feature requests on the issue tracker, we reserve it for issues. Would you start a discussion at https://discuss.rubyonrails.org/ or create a pull request? Thanks. Refer to https://github.com/rails/rails/issues/45847#issuecomment-1240340180