Yasuo Honda comments

Results 167 comments of


                                            Yasuo Honda

Cop to detect deprecated enums with keyword arguments

This good syntax like `enum :status, [ :active, :archived ]` has been introduced since Rails 7.0 via https://github.com/rails/rails/pull/41328 . Using this syntax for Rails 6.1 raises ``enum': wrong number of...

Cop to detect deprecated enums with keyword arguments

This good syntax like enum :status, [ :active, :archived ] works as expected for Rails 7.0.z - foo1238_70.rb ```ruby $ more foo1238_70.rb require "bundler/inline" gemfile(true) do source "https://rubygems.org" git_source(:github) {...

Improve 18c support

Could you please break this pull request into smaller pieces?

`test_render_mutate_string_literal` shows `inline template:1: warning: literal string will be frozen in the future`

I have not bisected the Ruby commit , I assume this is related to https://github.com/ruby/ruby/pull/10262

Add JSON output format option to `rails stats` command

Thanks for opening this pull request. Adding an option to the JSON format looks technically interesting. However, we usually ask for real-world use cases, not hypotheticals. Would you consider bringing...

Add JSON output format option to `rails stats` command

Thanks again for opening this pull request. Looking forward to further contributions.

Fix console_test to make pass after IRB's behavior change

Let's revisit this pull request once the newer version if irb that includes https://github.com/ruby/irb/pull/907

Fix console_test to make pass after IRB's behavior change

Thanks.

`rails` directory us mounted with `root` as an owner

I attempt to reproduce this issue and clone Rails repo files are owned by `vagrant` as expected. - At vagrant host, macOS ``` % ls MIT-LICENSE README.md Vagrantfile bootstrap.sh %...

Assets (Sprockets 4.1.1 and Sprockets-rails 3.4.2) not work correctly with images within engine with third party libraries

Here `contributor` is GitHub username that have sprockets-rails repository. ```ruby git clone https://github.com/contributor/sprockets-rails.git ``` Once you have cloned https://github.com/rails/sprockets-rails/ to your account the correct address should be ```ruby git clone...