Yasuo Honda

Results 167 comments of Yasuo Honda

Based on the git bisect result, this behavior had been introduced by this commit between Rails v6.0.0 and v6.0.1. https://github.com/rails/rails/commit/dd46d18e2108f2e953e9811c6eabf5b18fe77ab1 Then it has been addressed by this commit, which will...

Yes. I think we can merge #1176 and skip this test on v6.0.3. One concern is it fails against [Rails 6.1.0.rc1](https://github.com/activerecord-hackery/ransack/runs/1482073998?check_suite_focus=true) then we will need to find how to address...

I have opened #816 .

Yes. Let me tackle " Use environment variables not to update test/db/header.js file" first.

I have updated my pull request to use environment variables for login credentials. Here are 7 CI failures then I wanted someone to help address them. https://github.com/yahonda/pg-promise/runs/4152851966?check_suite_focus=true 1. These failures...

Even if there are CI failures I have removed "draft" from this pull request because I'd like to get some more reviews how to fix them.

We don't take feature requests on the issue tracker, we reserve it for issues. Would you start a discussion at https://discuss.rubyonrails.org/ or create a pull request? Thanks. Refer to https://github.com/rails/rails/issues/45847#issuecomment-1240340180

Addressed by https://github.com/rails/rails/commit/43a6b4fc0f7902e682d49933f84fa84642282393

Reopened another closed by stale label.

@OuYangJinTing Would you rebase this pull request based on the latest main branch if you are still interested in. Thanks.