Riccardo Magliocchetti

Results 338 comments of Riccardo Magliocchetti

@shivanshuraj1333 Please add a changelog and entry, also a test to check the changed behaviour would be nice

> Question: why do we want a fallback strategy to latin-1 for a wrong encoded value? And if we want it we also want tests

ASGI docs kinda suggests these should be ASCII but that's not mandatory so being less picky may be a good idea: headers: These are byte strings of the exact byte...

@rocky-ken we need some tests for this to get in

@shwejanraj as github interface says you have to merge main or rebase for us to merge

@kayhern this already out-of-date :sweat:

> @xrmx just checking in, have you had a chance to look at this and my responses to your comment? Not yet, sorry

> @emdneto, > > I added some testing but stopped short of the full auto instrumentation test. I stopped short because the maintainer of kafka-python has come back and is...

I think we can close this since native OTel support has been added in the elasticsearch client library itself and we gained sync support up to 8.