Riccardo Magliocchetti

Results 346 comments of Riccardo Magliocchetti

Looks like we are reaching some kind of limit and some tests won't run? Anyway there is at least pydantic to bump.

> So a question @xrmx : will otel only support Python 3.13 when all the instrumentation's work with 3.13? (could take a while for all those libraries to add support...

@antonpirker please clean your base branch so you don't have other people commits, thanks! Then it would be nice to open a new PR with the following commits so we...

@AWhetter thanks for reporting. We should probably run mypy in CI too to avoid regressions. Any chance you can provide a pull request?

Thought about this sometime ago here https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2409#discussion_r1651140187

Example of an instrumentation for a couple of different libraries https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2537

> So, probably a dumb question but why have more than one package in `instruments`? Currently that's the case when an instrumentation requires two packages installed, e.g. tortoiseorm or when...

Thanks for reporting and for the analysis, I think the typing is wrong since `time_to_perf_counter` expects the timestamp to be a float in seconds.

@Masterdanielsan Does https://github.com/elastic/apm-agent-python/pull/2335 fix the issue for you?