Riccardo Magliocchetti

Results 338 comments of Riccardo Magliocchetti

Fix merged and released, closing.

@obs-gh-abhishekrao There's no such thing of "its own scope of modules to auto-instrument", instrumentations declare entry-points we use to discover them. If they define these entry points we try to...

I understand the issue but it doesn't feel right to to add something ad-hoc per instrumentation

> I guess this issue can be closed? Indeed, thanks!

@mspillane please sign the CLA

Why are we taking the burden of maintaining an empty package upstream just for a re-export? Why not defining the entry point in your package so that people interested can...

> I'm not sure how the versioning of this package would work.. Do we just keep the version forever pinned at 0.1 ? Do we have to bump the version...

Have seen this just now but I've implemented more or less what you did. I think we should take a look at using getvalue() instead of read() as it should...

![8wgjxj](https://github.com/open-telemetry/opentelemetry-python-contrib/assets/12932/90cea392-433a-42a9-998c-fb81d1de905f)

@jgibo Have you taken a look on how the asyncio instrumentation handles things?