Riccardo Magliocchetti

Results 346 comments of Riccardo Magliocchetti

My thinking is that traces and logs are two different signals and so they should be ~independent.

Maybe I'm doing something wrong but with otel-python-k8s-samples (a7aef5d310e283ea8d3a4ddc5619003920d9abce) the Django application starts and works fine (I get "[Django] Ok! tracing outgoing http call") but I don't get any span...

> > No need for a new file, just add the testcase to the other file > > When you said other file, you meant this right? > > instrumentation/opentelemetry-instrumentation-boto/tests/test_boto_instrumentation.py...

@itsvshreyas linting will fail. Then we are going to drop this boto instrumentation in the future.

Good things is we are not tracing api using blobs at the moment :) Anyway I think this must be discussed at the genai semconv call https://docs.google.com/document/d/1EKIeDgBGXQPGehUigIRLwAUpRGa7-1kXB736EaYuJ2M/edit?tab=t.0#heading=h.ylazl6464n0c before doing anything...

Do you have a reproducer? Which version of urllib3?

Another similar: ``` _____ TestSqlalchemyMetricsInstrumentation.test_metrics_without_pool_name ______ self = def tearDown(self): super().tearDown() > SQLAlchemyInstrumentor().uninstrument() instrumentation/opentelemetry-instrumentation-sqlalchemy/tests/test_sqlalchemy_metrics.py:31: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _...

Flaky does not mean it fails everytime but that it fails sometime and often it's not easy to reproduce.

Another one ``` =================================== FAILURES =================================== ______ TestSqlalchemyMetricsInstrumentation.test_metrics_two_connections _______ self = def tearDown(self): super().tearDown() > SQLAlchemyInstrumentor().uninstrument() instrumentation/opentelemetry-instrumentation-sqlalchemy/tests/test_sqlalchemy_metrics.py:31: _ _ _ _ _ _ _ _ _ _ _ _ _...