Riccardo Magliocchetti

Results 344 comments of Riccardo Magliocchetti

Thanks for contributing but all 3 of you need to sign he CLA in order to get the code accepted

> Can this be merged if everything is ok? This should be splitted per https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2492#issuecomment-2203873674

@rjduffner My preferred approach would be something like this but unfortunately we are using a field with the semantics already defined (must be strings) https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2409

@Sunilwali679 please setup pre-commit (and fix linting) and rebase

> @xrmx Done the rebase and submitted for review It looks like you missed the pre-commit setup :sweat_smile:

Thanks for reporting, that means that we are not running tests for this instrumentation on windows I guess :sweat:

@omikader please give it a try! You have to: - update project.optional-dependencies in pyproject.toml - update src/opentelemetry/instrumentation/mysql/package.py - add a new version of test-requirements.txt using version 9 of the library...

Maybe I am late but would adding a single environment variable that takes a list of additional attributes to export would be more acceptable? The caveat would be to require...