starknet-rs icon indicating copy to clipboard operation
starknet-rs copied to clipboard

Full documentation coverage on public items

Open xJonathanLEI opened this issue 3 years ago • 4 comments

There's currently very little documentation. We need to:

  • [ ] achieve full doc coverage on all public items on all crates
  • [ ] add #![deny(missing_docs)] to all crates to enforce documentation

xJonathanLEI avatar Jan 07 '22 08:01 xJonathanLEI

Maybe use ChatGPT to help with this?

xJonathanLEI avatar Dec 06 '22 16:12 xJonathanLEI

I would love to work on this. Any particular pattern/format you would want to follow for the documentation?

omarespejel avatar Jan 20 '23 01:01 omarespejel

Thanks @omarespejel! I guess it's best to follow existing items that already have some docs. e.g.

https://github.com/xJonathanLEI/starknet-rs/blob/f7cc49ea99aaccbfb2465fe8fb665bdff21da044/starknet-ff/src/lib.rs#L147-L156

xJonathanLEI avatar Jan 20 '23 01:01 xJonathanLEI

Makes sense! Thank you @xJonathanLEI.

omarespejel avatar Jan 20 '23 02:01 omarespejel

Basic documentation now exists for all crates. The docs are by no means extensive. In most cases they're just basic description of what the type/method does, without giving code examples. Nevertheless, this issue should now be considered completed.

xJonathanLEI avatar Jul 29 '24 09:07 xJonathanLEI