Simon Wisselink comments

Results 211 comments of


                                            Simon Wisselink

modifier default not working with @ suppression

The default modifier has already been changed to longer use the @ modifier in https://github.com/smarty-php/smarty/pull/629

New Smarty Variable or asset

Sorry, I can't follow you. Is there a problem you are trying to fix?

PHP 8 focused error handler should also accept PHP 7 notices

@Rambomst do you have a code example that triggers the error? I'll add a unit test and merge it asap

Make SmartyCompilerException play nicer with error handler libraries

I like this fix very much, but as you mention, it would require a new major release. What if we keep the public properties template, source and desc and 'fix'...

Make SmartyCompilerException play nicer with error handler libraries

For now, I'd just add them back. If we choose to deprecate them in the future, option 2 can be implemented then.

#155 Adapt Smarty upper/lower functions to be codesafe (e.g. for Turkish locale)

@lkppo cool!

address PHP 8.1 'explode', 'number_format', and 'replace' deprecations

This seems great at first glance, and all the tests seem to be passing. However, it feels a bit weird to start providing wrappers for native PHP-functions, only to prevent...

address PHP 8.1 'explode', 'number_format', and 'replace' deprecations

@mfettig @rudiedirkx you are both right. I've given it some thought, and I think we should go forward in the direction you propose. One way out of the never ending...

strtolower in Autoloader.php won't work using tr_TR locale

@JulienPalard I can confirm this issue still exists. I've beem doing a little debugging, but it seems we need to fix `ucfirst` too? Without fixing that I quickly run into...

#623 Static return type in docblocks; for better IDE support chaining

@blaaat Wouldn't `@return $this` be more appropriate here?