Simon Wisselink

Results 211 comments of Simon Wisselink

I was hoping for someone to implement a BC layer for strftime, so yes, using that would seem to be the best way forward. Changing the syntax is a no...

https://packagist.org/packages/php81_bc/strftime seems like a great bridge to solve the strftime compatibility issue, but it requires the Intl extension, so now Smarty requires the Intl extension, so that is a breaking...

@lkppo thank you for your admiration ;) After some fruitful discussion with @doekenorg I came to my senses and decided that we don't need to bug users with deprecation notices...

The double brackets cause nested behavior. Smarty probably parses the inner `{/foreach}` first and then tries to output the "result" of that statement. And there indeed seems to be a...

[Modifiers](https://www.smarty.net/docs/en/language.modifiers.tpl) were not intended to be used on built in functions (as stated in the docs). It seems that applying modifiers to include did in fact work, however in 3.1.29...

> What I'd like to see with this is smarty throwing some sort of compile error if using a modifier where I shouldn't. Simply swallowing it seems wrong, is that...

Definitely a security risk, esp when users on a website can provide their own mail address in a profile for example. And there's an issue with html escaping not being...

Savvy Smarty users might have circumvented this bug by doing `{mailto address=$htmladdress|escape}` and it will not be possible to detect this, which might cause double escaping. We should probably warn...

There appear to be a few problems with the unit tests now. Could you look into this? Don't get me wrong: I'm happy with all the effort you put in,...

Failing unit tests means no merge, I'm afraid. And AFAIK deprecation notices aren't a show stopper. They exist to inform us ahead of time that some functionality will change in...