Simon Wisselink comments

Results 211 comments of


                                            Simon Wisselink

#623 Static return type in docblocks; for better IDE support chaining

But we're not dropping php7 support, right?

Necessity of mb_internal_encoding in Smarty::__construct() is questionable

@AnrDaemon how far are you on this one? If this requires making a breaking change (I could imagine some older projects implicitly relying on Smarty to change the internal encoding...

PHP8.2 compatibility

Please have a look at the unit tests? There are still failures.

PHP8.2 compatibility

CI is running. Can you explain the changes to the escape modifier compiler? It seems different in the way the methods are nested.

PHP8.2 compatibility

@Progi1984 this looks great! I'll double check the encoding/escaping change and merge asap.

Smarty Syntax Error

Could you show your template source and list the versions of Smarty and PHP you are using?

Drop support for using PHP functions as modifiers

#814 was incorrectly marked to close this. It's only the first step.

reset($array)['key'] does not work as expected: SmartyCompilerException Syntax error in template - Unexpected "[", expected one of: "}"

@j-applese3d although I can see why you would expect this (as the Smarty syntax is obviously inspired on PHP syntax) there is nothing that requires Smarty to follow everything PHP...

reset($array)['key'] does not work as expected: SmartyCompilerException Syntax error in template - Unexpected "[", expected one of: "}"

I'm not sure what you mean exactly, but these all work perfectly: ``` $smarty = new Smarty(); $smarty->assign('myarr', ['a' => 'A', 'b' => 2, 0 => 15, 1 => [0...

Construction: switch - case

We could, but it's not on the roadmap. I'll leave this issue open to see if more people are interested.