smarty
smarty copied to clipboard
#155 Adapt Smarty upper/lower functions to be codesafe (e.g. for Turkish locale)
This PR changes the ucfirst
/lcfirst
/strtoupper
/strtolower
calls in the code that work with method, class, and variable names. These calls are replaced with equivalents (e.g. using strtr
) that do not change depending on the system locale. This resolves a problem in particular with tr_TR
, for which strtolower('I') != 'i'
.
Hello,
I need also this fix for a Turkish translation of Wikindx users.
Regards,
I am also waiting for this fix. Thanks.
PHP RFC: Locale-independent case conversion corrects it for PHP 8.2.
@lkppo cool!
Isn't it! I have patched my code with this PR for several months and it is working fine. By the way, I factored with functions ucfirst_ascii(), strtolower_ascii() to minimize the modifications.
Hi @wisskid,
Thanks for merging this PR. My hand patching can go now!
Regards,