Simon Wisselink
Simon Wisselink
See https://github.com/smarty-php/smarty/pull/569/files
@alexgit2k thanks for the detailed report. Could I tempt you to make a PR for Smarty 4?
This is now fixed by https://github.com/smarty-php/smarty/pull/755 with only the strftime issue remaining, but we have a seperate issue for strtime (see https://github.com/smarty-php/smarty/issues/672 )
Hi @EDCScott . I've reviewed your changes and I see no problem in allowing for an underscore the regex. The changing of the max length might be a problem, though....
> @wisskid did you backport these changes manually? If so, feel free to close this PR. @AnrDaemon yes, I did. https://github.com/smarty-php/smarty/commit/20a8026ccd6970432a789dfe2941655b4d7e2617
That is interesting, I'll see if I can find where it originates.
Caused by a change in v3.1.28
> How about changing L~342 > > ``` > $output .= $foreachCompiler->compileRestore(1); > ``` > > to > > ``` > $levels = (!is_null($restore) && $restore > 1) ? $restore...
I have a fix: ``` diff --git a/libs/sysplugins/smarty_internal_runtime_foreach.php b/libs/sysplugins/smarty_internal_runtime_foreach.php index badead16..d55ad576 100644 --- a/libs/sysplugins/smarty_internal_runtime_foreach.php +++ b/libs/sysplugins/smarty_internal_runtime_foreach.php @@ -56,12 +56,6 @@ class Smarty_Internal_Runtime_Foreach if (!isset($total)) { $total = empty($from) ? 0...
Not sure if we should “fix” this, as described above. It is admittedly a bit quirky, but fixing it would require breaking stuff that is actually tested for in the...