Simon Wisselink

Results 211 comments of Simon Wisselink

> how do they fail, actually? > I did test them (the three you mentioned above) and all 3 worked well. ```sh $ php7.1 vendor/phpunit/phpunit/phpunit --stop-on-failure --exclude-group slow tests/UnitTests/TemplateSource/TagTests/Foreach/CompileForeachTest.php PHPUnit...

getTags does indeed not provide any information on the variable being printed in a simple `{$var}` field. Might be useful. test.tpl ``` {foreach $categories as $category} {$category->name} {/foreach} ``` test.php...

Seeing that this is all very deprecated and discouraged, I'm in favor of fixing the docs to reflect the way it works now. @mohrt could you change `$this` in Example...

@mohrt could you change $this in Example 7.62 on https://www.smarty.net/docs/en/language.function.php.tpl to $_smarty_tpl?

Could you provide an example and the Smarty version you were using before?

@Culprit-CZ wouldn't problems like that be expected when multi threading? Is there any way you can compile/cache templates before going into multi thread?

@mikehageman could you provide a little more context? E.g. a line of an actual template?

@mikehageman thank you! We don't suppor the nullsafe operator yet. I'll put it on the backlog, cause it looks very much worth considering.

@Miksser @antman3351 I've added an empty check for variables for `|default` modifier in #650 . It does not appear to break anything. Can you confirm this fixes your problem?

Well spotted, @antman3351 ! Not sure how that got past me. I thought I ran the new unit tests against the old code (seeing no change in behavior) but I...