Bill Wallace

Results 50 comments of Bill Wallace

No, if they set it specifically to 10 then it can stay as 10. On Thu, 5 May 2022 at 11:42, Alireza ***@***.***> wrote: > ***@***.**** commented on this pull...

@sedghi - can you take a quick look, very simple fix.

This change can be committed independently now from the hanging protocol change, but I would have to extract the HP stuff first, so that this one can go on top...

You will have to explain where the software is incompatible. It SHOULD read DICOS files, although I'm definitely not very familiar with them to know. Please attach a test case...

Will look as soon as the test is available.

Will try to get a PR for this by the end of the day - I have a fix for it already, just need to add a unit test. I...

I have a PR for this right now, but the issue exposes the fact that the normalized data refers to the original data, so modifying it will modify the original/underlying...

Please just use Array.isArray, drop the two extra files, and add a unit test.

Generally LGTM - if we use a custom TSUID. Hopefully Erik can take a look as I'm not terribly familiar with the details of exactly where the codec is created.

@pieper - can I have your thoughts on implementing this one? I was going to modify my local copy to handle either response type and submit a PR for it.