Viewers
Viewers copied to clipboard
feat(syncGroups):Add registration for new synchronizers
Adds a registration capability to add new synchronizers Based off the hanging protocol PR, but is intended to merge after that one. @sedghi and @swederik - this is a modified design that allows creating new synchronizers. There is also a bit more cleanup of types in the hanging protocol area to make that cleaner. The only connection between hanging protocols and the syncrhonizers is the existing syncGroups - otherwise, that area is actually identical. I do not yet have an example synchronizer fully worked out, but I didn't want to do that until you had seen it.
Codecov Report
Merging #2861 (55ea72d) into v3-stable (9f1e813) will increase coverage by
12.15%
. The diff coverage isn/a
.
:exclamation: Current head 55ea72d differs from pull request most recent head d056812. Consider uploading reports for the commit d056812 to get more accurate results
@@ Coverage Diff @@
## v3-stable #2861 +/- ##
==============================================
+ Coverage 25.15% 37.31% +12.15%
==============================================
Files 119 102 -17
Lines 2862 2152 -710
Branches 555 442 -113
==============================================
+ Hits 720 803 +83
+ Misses 1856 1104 -752
+ Partials 286 245 -41
Impacted Files | Coverage Δ | |
---|---|---|
...tform/core/src/services/CineService/CineService.js | 12.50% <0.00%> (-6.25%) |
:arrow_down: |
.../services/MeasurementService/MeasurementService.js | 47.23% <0.00%> (-1.96%) |
:arrow_down: |
platform/core/src/classes/CommandsManager.js | 90.69% <0.00%> (-1.14%) |
:arrow_down: |
platform/core/src/classes/MetadataProvider.js | 4.72% <0.00%> (-0.54%) |
:arrow_down: |
...core/src/services/ToolBarService/ToolBarService.js | 1.36% <0.00%> (-0.13%) |
:arrow_down: |
platform/viewer/src/index.js | 0.00% <0.00%> (ø) |
|
platform/viewer/src/appInit.js | 0.00% <0.00%> (ø) |
|
platform/core/src/utils/index.js | 100.00% <0.00%> (ø) |
|
platform/core/src/DataSources/IWebApiDataSource.js | 11.11% <0.00%> (ø) |
|
...services/DicomMetadataStore/createStudyMetadata.js | 0.00% <0.00%> (ø) |
|
... and 45 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1b30ff8...d056812. Read the comment docs.
Test summary
Run details
Project | Viewers |
Status | Passed |
Commit | d056812372 |
Started | Sep 9, 2022 12:27 PM |
Ended | Sep 9, 2022 12:29 PM |
Duration | 02:16 💡 |
OS | Linux Debian - 11.3 |
Browser | Chrome 103 ![]() |
View run in Cypress Dashboard ➡️
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
This change can be committed independently now from the hanging protocol change, but I would have to extract the HP stuff first, so that this one can go on top of v3-stable
Deploy Preview for ohif-platform-docs ready!
Name | Link |
---|---|
Latest commit | d056812372f8163cc489a111194adc61929ea2c1 |
Latest deploy log | https://app.netlify.com/sites/ohif-platform-docs/deploys/631b2f765866850009a88b2c |
Deploy Preview | https://deploy-preview-2861--ohif-platform-docs.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Deploy Preview for ohif-platform-viewer ready!
Name | Link |
---|---|
Latest commit | d056812372f8163cc489a111194adc61929ea2c1 |
Latest deploy log | https://app.netlify.com/sites/ohif-platform-viewer/deploys/631b2f760b0794000978e4e8 |
Deploy Preview | https://deploy-preview-2861--ohif-platform-viewer.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.