Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

fix(OHIFv3):Allow multiple study UIDs in the path.

Open wayfarer3130 opened this issue 2 years ago • 5 comments

The wrong call was being made to fetch the study instance uids, so it wasn't possible to fetch two or more instances at once.

wayfarer3130 avatar May 27 '22 12:05 wayfarer3130

Deploy Preview for ohif-platform-viewer ready!

Name Link
Latest commit b9006d59edc103221b93668df2e15ab02b4c1c49
Latest deploy log https://app.netlify.com/sites/ohif-platform-viewer/deploys/635acf72fa34a90008515ece
Deploy Preview https://deploy-preview-2815--ohif-platform-viewer.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar May 27 '22 12:05 netlify[bot]

Deploy Preview for ohif-platform-docs canceled.

Name Link
Latest commit b9006d59edc103221b93668df2e15ab02b4c1c49
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/635acf72bad8e2000824caaf

netlify[bot] avatar May 27 '22 12:05 netlify[bot]

@sedghi - can you take a quick look, very simple fix.

wayfarer3130 avatar May 27 '22 12:05 wayfarer3130

Codecov Report

Merging #2815 (b9006d5) into v3-stable (9f1e813) will increase coverage by 12.35%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           v3-stable    #2815       +/-   ##
==============================================
+ Coverage      25.15%   37.51%   +12.35%     
==============================================
  Files            119      101       -18     
  Lines           2862     2154      -708     
  Branches         555      440      -115     
==============================================
+ Hits             720      808       +88     
+ Misses          1856     1103      -753     
+ Partials         286      243       -43     
Impacted Files Coverage Δ
...tform/core/src/services/CineService/CineService.js 12.50% <0.00%> (-6.25%) :arrow_down:
.../services/MeasurementService/MeasurementService.js 47.23% <0.00%> (-1.96%) :arrow_down:
platform/core/src/classes/CommandsManager.js 90.69% <0.00%> (-1.14%) :arrow_down:
platform/core/src/classes/MetadataProvider.js 4.54% <0.00%> (-0.72%) :arrow_down:
...core/src/services/ToolBarService/ToolBarService.js 1.36% <0.00%> (-0.13%) :arrow_down:
platform/viewer/src/index.js 0.00% <0.00%> (ø)
platform/viewer/src/appInit.js 0.00% <0.00%> (ø)
platform/core/src/utils/index.js 100.00% <0.00%> (ø)
platform/core/src/utils/isImage.js 100.00% <0.00%> (ø)
platform/core/src/services/ServicesManager.js 100.00% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2507a4b...b9006d5. Read the comment docs.

codecov[bot] avatar May 27 '22 13:05 codecov[bot]



Test summary

20 0 0 0


Run details

Project Viewers
Status Passed
Commit b9006d59ed
Started Oct 27, 2022 6:41 PM
Ended Oct 27, 2022 6:42 PM
Duration 01:17 💡
OS Linux Debian - 11.3
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar May 27 '22 13:05 cypress[bot]

I tried it like this

http://localhost:3000/viewer?StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.7009.2403.334240657131972136850343327463&StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.7009.2403.459769504433903221904322299373

and it showed me 4 studies instead of two

image

How should i try it?

sedghi avatar Oct 07 '22 02:10 sedghi

@sedghi - this is working again. There was a bug in the panel study browser causing the studies to be loaded twice.

wayfarer3130 avatar Oct 27 '22 18:10 wayfarer3130