Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

fix: Crash/hang issues and a minor log issue

Open wayfarer3130 opened this issue 2 years ago • 1 comments

Fixing some crash/hang issues in CS3D version of OHIF.

wayfarer3130 avatar May 04 '22 19:05 wayfarer3130

No, if they set it specifically to 10 then it can stay as 10.

On Thu, 5 May 2022 at 11:42, Alireza @.***> wrote:

@.**** commented on this pull request.

In extensions/cornerstone-3d/src/initWADOImageLoader.js https://github.com/OHIF/Viewers/pull/2792#discussion_r866055085:

@@ -13,7 +13,7 @@ function initWebWorkers(appConfig) { const config = { maxWebWorkers: Math.min( Math.max(navigator.hardwareConcurrency - 1, 1),

  •  appConfig.maxNumberOfWebWorkers
    
  •  appConfig.maxNumberOfWebWorkers || 3
    

but if it is set and it is let's say 10, 10||3 is 10, but don't you want it to be 3?

— Reply to this email directly, view it on GitHub https://github.com/OHIF/Viewers/pull/2792#discussion_r866055085, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGT56XMUENNJB4F6LTGAN7DVIPT63ANCNFSM5VC4UAVQ . You are receiving this because you authored the thread.Message ID: @.***>

wayfarer3130 avatar May 05 '22 18:05 wayfarer3130