Adrian Brock

Results 191 comments of Adrian Brock

I don't think you should be breaking something in api like this? Why not: ```` // Old method for backwards comaptibilty (in case somebody else is using it) @Deprecated String...

You are also not doing the same validation when registering a list: ```` public static boolean registerTooltip(Fluid fluid, List tooltip) { if (fluid != null && tooltip != null &&...

One more suggestion, I think the return value for the new method should be implemented something like: ```` public static boolean registerTooltip(Fluid fluid, List tooltips) { boolean result = false;...

mutablility of local variables/parameters is fine mutability is an issue when it is shared state across threads.

> Additionally, I am not sure why we are using Java's Iterable.forEach() when it has worse performance and worse readability in stacktraces. It's swings and roundabouts. Iterable.forEach() can be optimised...

What issue does freezing the registry solve? Is there something like block or color registration where you will "miss the bus" if you register too late? Or the other use...

> To me, this proposed solution seems like more code than it needs to be compared to moving it to a first-tick update check My argument is that it is...

An alternative approach is to re-write the redstone cache so that it works under a lazy initialisation protocol. This is a much more invasive change, but it would have the...

For point (1) above, I have added an IConfigurable.getConfigurationName() This is now displayed in the tooltip of the configurator so a user can see what configuration it holds. It is...

I changed the IConfigurable to not use an EntityPlayer directly and instead use a context object. This will allow additional information to be passed, e.g. whether it should use advanced...