Victor Zverovich comments

Results 199 comments of


                                            Victor Zverovich

consteval error with FreeBSD 13.1 and Clang13

@mpiatka, the error in your example is unrelated and expected because the format string should be known at compile time: https://fmt.dev/latest/api.html#core-api.

consteval error with FreeBSD 13.1 and Clang13

@phire, could you provide a repro (ideally on godbolt)?

consteval error with FreeBSD 13.1 and Clang13

> But maybe you should update master to check for _LIBCPP_VERSION instead of __apple_build_version__. I don't think it's a good idea because this config works on some systems, e.g. https://godbolt.org/z/rMcYPj66P.

consteval error with FreeBSD 13.1 and Clang13

I wasn't able to repro the issue on the following test case: test.cc: ```c++ #include int main() { uint64_t full_u64; auto s = fmt::format("{:02x}", full_u64); } ``` ``` % uname...

Add consteval format string checks for wide strings

Yeah, compile-time checks are currently enabled for the `char` overloads only.

Add consteval format string checks for wide strings

We also need to do this for function taking text styles and potentially named arguments.

Add consteval format string checks for wide strings

This has been implemented in {fmt} v9.

Support std::exception

Sure, a PR to add a formatter specialization is welcome.

undefined symbol: protected: virtual bool __cdecl fmt::v9::format_facet<class std::locale>::do_put --- while linking format-test.exe using clang-msvc

Not sure why clang-msvc is complaining because the function in question is defined here: https://github.com/fmtlib/fmt/blob/94ceb38a0943c50ea9939050a7f4e8e4c9da43d2/include/fmt/format-inl.h#L144-L145

fmt::printf("%.*f\n", 15, pi) makes linking fails unless linking against static lib or FMT_HEADER_ONLY defined.

Closing per email comment: > Now the current master [192859c](https://github.com/fmtlib/fmt/tree/192859c2b5dda3a015a7b1bf023f0c2475f0350c) doesn't have this issue. However the issue still shows on compiler explorer as link above. > You may close this....