Martijn Visser

Results 193 issues of Martijn Visser

@ghendrickx has started adding ContinuousControl nodes to his models, and the Python validation now keeps on giving warnings like "Following from_node_id's in the link table do not exist". The `from_node_id`...

python

Sometimes the best way to model a single physical structure is to divide it into several nodes. A simple example is a bidirectional Pump, which you can model as two...

needs-refinement
reservoir

Currently the regression tests are run on TeamCity with ``` pixi run python utils/get_benchmark.py --secretkey %MiniO_credential_token% "benchmark/" pixi run python utils/get_benchmark.py --secretkey %MiniO_credential_token% "hws_migration_test/" pixi run test-ribasim-regression ``` https://github.com/Deltares/Ribasim/blob/b242513f6f7d398f23a775dddfa8c248bec6a768/.teamcity/Templates/RegressionTest.kt#L74-L76 It...

CI/CD

From [v2024.11.0](https://github.com/Deltares/Ribasim/releases/tag/v2024.11.0) to [v2025.1.0](https://github.com/Deltares/Ribasim/releases/tag/v2025.1.0) the `ribasim_windows.zip` size grew from 230 MB to 313 MB. We should investigate why and see if we can get it back to the old size....

core

``` │ WARNING: Detected access to binding `Ribasim.ParameterUpdate` in a world prior to its definition world. │ Julia 1.12 has introduced more strict world age semantics for global bindings. │...

core

The integration tests compare the output states of the HWS model. For #2136 I needed a quick way to eyeball the differences on the map. Sharing my throw-away script here...

python

We currently use these icons for the different node types: ![Image](https://github.com/user-attachments/assets/8000de47-df37-45f9-9b58-494c3d3c3995) The image above are the QGIS QML markers defined here: https://github.com/Deltares/Ribasim/blob/v2025.2.0/python/ribasim/ribasim/styles/NodeStyle.qml We also have icons defined for Ribasim Python's...

python
QGIS

If we load the results from `model.to_xugrid` we see https://github.com/Deltares/Ribasim/pull/1369. Links: look ok, but we only write the direct link and not the linestring that may be following the waterway....

python
QGIS

Like [#2178](https://github.com/Deltares/Ribasim/issues/2178)

Delft-FEWS

A negative `flow_rate` in `flow.arrow` means that it flows in the opposite direction of the edge, which can happen, depending on the node types used. The spatial results of the...

Delft-FEWS