Martijn Visser

Results 193 issues of Martijn Visser

This probably has similarities to #2166. To be able to debug allocation results over time and space we probably need support in FEWS. These are the two result files for...

allocation
Delft-FEWS

Right now our [installation docs](https://ribasim.org/install.html) is not bad, but it is a bit laborious to install all 3 components and have them work together nicely. The install Ribasim Python instructions...

documentation

@SouthEndMusic An update of JuliaInterpreter (I assume) has killed our beautiful trace code: ```julia graph, verts = tracecall((Ribasim,), Ribasim.Parameters, (db, config)) ------------------ MethodError: no method matching finish_and_return!(::typeof(log_far!), ::Frame, ::Bool) The...

Since #280 we define profiles with $A(h)$, integrating in the core to get the $S(h)$. For many reservoirs only the $S(h)$ is known, and asking users to convert to $A(h)$...

reservoir

We could do this similar to (parts of) #1909, as long as it is clearly communicated.

documentation

~~Before merging~~ we should look a bit more into this regression in the number of allocations: ``` hws_2024_7_0 (before, after) 29.171531 seconds (1.60 M allocations: 2.987 GiB, 1.07% gc time)...

performance
core

https://ribasim.org/dev/core.html is quite outdated. Rather than the julia REPL commands we should promote the pixi tasks since they also make sure that e.g. the testmodels are generated and juliaup is...

documentation

As mentioned in https://github.com/Deltares/Ribasim/pull/2251#issuecomment-2830502002, #2251 caused a regression in our integration test benchmark `hws_2024_7_0`. I did some quick benchmarks: ``` after refactor d86698201c9bab0f95323d13821b56ecc0bfa93d hws_2024_7_0 initialization 0.121077 seconds (953.86 k allocations:...

core

Mainly getting the infrastructure set up for now. Starting with: - [ ] https://github.com/Deltares/Wflow.jl/issues/576 - [ ] https://github.com/Deltares/Wflow.jl/issues/577 Name: WflowLand?

core

Locally I cannot run `pixi run generate-testmodels`. It tends to fail on `basic` or `basic_arrow`. I have no idea why this started happening now. It looks like `self.filepath = filepath`...

python